> On June 27, 2016, 4:11 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 808-809 > > <https://reviews.apache.org/r/49281/diff/1/?file=1431239#file1431239line808> > > > > Can we use a consistent comment in all places?
I opted to remove the TODOs from the implementations, because the interface's TODOs read `all implementations do ...` and the TODO applies to both `Socket::accept` and `Socket::create`. The TODO is consistent inside the interface though :) > On June 27, 2016, 4:11 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/socket.hpp, line 273 > > <https://reviews.apache.org/r/49281/diff/1/?file=1431238#file1431238line273> > > > > Can you reference a JIRA with this `TODO`? Created https://issues.apache.org/jira/browse/MESOS-5729 - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49281/#review139689 ----------------------------------------------------------- On June 27, 2016, 6:30 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49281/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 6:30 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-5723 > https://issues.apache.org/jira/browse/MESOS-5723 > > > Repository: mesos > > > Description > ------- > > All sockets made by libprocess are, by default, nonblocking and not > inherited by forks. This is the opposite of the Linux default. > > Nonblocking is a requirement of libprocess, but "close-on-exec" is not. > The latter should be modify-able by the user of libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 9b3abcfaf6cfb33290ccdb957801c0d029d78745 > > Diff: https://reviews.apache.org/r/49281/diff/ > > > Testing > ------- > > Comment change only. > > > Thanks, > > Joseph Wu > >
