-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49598/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Yubo Li.
Bugs: MESOS-5779
https://issues.apache.org/jira/browse/MESOS-5779
Repository: mesos
Description
-------
The `docker::spec::v1::ImageManifest` protobuf implements the
official v1 image manifest specification found at:
https://github.com/docker/docker/blob/master/image/spec/v1.md
The field names in this spec are all written in snake_case as are the
field names of the JSON representing the image manifest when reading
it from disk (for example after performing a `docker save`). As such,
the protobuf for ImageManifest also provides these fields in
snake_case. Unfortunately, the `docker inspect` command also provides
a method of retrieving the JSON for an image manifest, with one major
caveat -- it represents all of its top level keys in CamelCase.
To allow both representations to be parsed in the same way, we
intercept the incoming JSON from either source (disk or `docker
inspect`) and convert it to a canonical snake_case representation.
Diffs
-----
src/docker/spec.cpp 2711578626dd1847f73cbf7bd3771f36e6755a99
src/tests/containerizer/docker_tests.cpp
49bd7c252c342c8cb29ea916ad3f1f71638d2017
Diff: https://reviews.apache.org/r/49598/diff/
Testing
-------
`sudo GTEST_FILTER="*ROOT_DOCKER_CompareImageManifests" bin/mesos-tests.sh`
Thanks,
Kevin Klues