----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49242/#review141322 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/agent/agent.proto (line 157) <https://reviews.apache.org/r/49242/#comment206822> Let's also specify the unit of size. // The size of file (in bytes). include/mesos/agent/agent.proto (line 160) <https://reviews.apache.org/r/49242/#comment206823> Let's kill this comment since it's self explanatory i.e. the field-name + top level comment over `ReadFile` already has this information. - Anand Mazumdar On July 8, 2016, 11:48 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49242/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 11:48 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5515 > https://issues.apache.org/jira/browse/mesos-5515 > > > Repository: mesos > > > Description > ------- > > Add ReadFile message in the Response message of master.proto > , v1/master.proto, agent.proto, v1/agent.proto. > > > Diffs > ----- > > include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 > include/mesos/master/master.proto d82b2456fb78c385dd9fa92606ab72aa1ef5a729 > include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc > include/mesos/v1/master/master.proto > 711a664724d433af51bfb3ba73462e1842e06a87 > > Diff: https://reviews.apache.org/r/49242/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
