> On July 8, 2016, 5:49 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3640 > > <https://reviews.apache.org/r/49616/diff/3/?file=1439340#file1439340line3640> > > > > I think that the reason you want to use `batch` is because you want to > > speed up the test by decrease the whole loop here, if so, can you please > > update the comments a bit for why you want to use `batch` here? > > > > Such as following: > > > > // TODO(jjanco): Parameterize the test by batch size, not an arbitrary > > number. This can help reduce the total loop of benchmark test and speed up > > this unit test.
Yes, exactly, adding to the comment. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141251 ----------------------------------------------------------- On July 8, 2016, 5:55 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 5:55 p.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check > > > Thanks, > > Jacob Janco > >
