> On July 8, 2016, 5:54 a.m., Guangya Liu wrote: > > Another nit is that in `Testing Done` section, it is better add some > > testing command and test data but not only `make check`. > > > > Such as following: > > > > GLOG_v=1 ./bin/mesos-tests.sh --benchmark > > --gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2" > > [==========] Running 1 test from 1 test case. > > [----------] Global test environment set-up. > > [----------] 1 test from > > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > > [ RUN ] > > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2 > > Using 1000 agents and 100 frameworks > > allocate() took 905223us to make 1000 offers with 20 out of 100 frameworks > > suppressing offers > > allocate() took 899943us to make 1000 offers with 40 out of 100 frameworks > > suppressing offers > > allocate() took 943203us to make 1000 offers with 60 out of 100 frameworks > > suppressing offers > > allocate() took 918019us to make 1000 offers with 80 out of 100 frameworks > > suppressing offers > > allocate() took 92340us to make 0 offers with 100 out of 100 frameworks > > suppressing offers > > [ OK ] > > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2 > > (7279 ms) > > [----------] 1 test from > > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (7279 ms total) > > > > [----------] Global test environment tear-down > > [==========] 1 test from 1 test case ran. (7288 ms total) > > [ PASSED ] 1 test.
Agreed, I'll add this. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141253 ----------------------------------------------------------- On July 8, 2016, 5:55 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 5:55 p.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check > > > Thanks, > > Jacob Janco > >
