----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141605 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line 44) <https://reviews.apache.org/r/49813/#comment206945> I do not think we should write comments with `/**`, instead, we should always use `//`. You may need to update the comments in all the files. src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line 45) <https://reviews.apache.org/r/49813/#comment206941> s/. And delegate/, and delegates/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 101 - 116) <https://reviews.apache.org/r/49813/#comment206942> Suggest to change to: ``` struct Info { Info(const ContainerID& _containerId, const std::string& _cgroup) : containerId(_containerId), cgroup(_cgroup) {} const ContainerID containerId; const std::string cgroup; // This promise will complete if a container is impacted // by a resource limitation and should be terminated. process::Promise<mesos::slave::ContainerLimitation> limitation; }; ``` src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 170 - 171) <https://reviews.apache.org/r/49813/#comment206943> Suggest to change: ``` the hierarchy path '/cgroup/cpu,cpuacct' co-mounted two subsystems: `cpu` and `cpuacct`. ``` to: ``` Subsystem 'cpu' and 'cpuacct' are co-mounted at '/cgroup/cpu,cpuacct'. ``` src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 36 - 37) <https://reviews.apache.org/r/49813/#comment206947> Why do you do the forward declaration rather than include cgroups.hpp? src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 145 - 147) <https://reviews.apache.org/r/49813/#comment206946> I think we can merge these 3 lines into 1 line which will not exceed 80 chars. - Qian Zhang On July 9, 2016, 6:16 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49813/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 6:16 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added stubs for the unified cgroups isolator. > > > Diffs > ----- > > src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 > src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49813/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
