----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review142173 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line 53) <https://reviews.apache.org/r/49813/#comment207727> Let's not introduce this method yet. It's not clear if that's needed from this patch. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 56 - 58) <https://reviews.apache.org/r/49813/#comment207733> Kill this one first. Introduce when it's needed. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 60) <https://reviews.apache.org/r/49813/#comment207734> I would put `flags` as the first parameter. That's the case for most our code base. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 72 - 80) <https://reviews.apache.org/r/49813/#comment207738> Let's introduce this method later. It's hard to tell and review if that's needed. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 106) <https://reviews.apache.org/r/49813/#comment207736> Let's put each parameter in it own line to match we we did in the isolator. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 117) <https://reviews.apache.org/r/49813/#comment207737> Ditto here. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 152 - 158) <https://reviews.apache.org/r/49813/#comment207739> Ditto. Introduce this later. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (lines 165 - 171) <https://reviews.apache.org/r/49813/#comment207740> Ditto. Remove this in this patch. - Jie Yu On July 13, 2016, 6:42 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49813/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 6:42 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added stubs for the unified cgroups isolator. > > > Diffs > ----- > > src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 > src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49813/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
