> On July 10, 2016, 9:50 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 36-37 > > <https://reviews.apache.org/r/49813/diff/2/?file=1440351#file1440351line36> > > > > Why do you do the forward declaration rather than include cgroups.hpp?
Because we include `slave/containerizer/mesos/isolators/cgroups/subsystem.hpp` in `src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp`. If we include `src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp` in `slave/containerizer/mesos/isolators/cgroups/subsystem.hpp`, it would bring circular dependencies. So I forward declaration here. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141605 ----------------------------------------------------------- On July 9, 2016, 10:16 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49813/ > ----------------------------------------------------------- > > (Updated July 9, 2016, 10:16 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Added stubs for the unified cgroups isolator. > > > Diffs > ----- > > src/CMakeLists.txt 760519c5568d22f778980b25c3dfedc3c8ef83b1 > src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49813/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
