----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142104 -----------------------------------------------------------
Ship it! I committed this patch and helped address some style issues while committing. Please take a look at the final patch and see what needs to be taken care of next time. Thanks! - Jie Yu On July 12, 2016, 4:14 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49208/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 4:14 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added tests to check if appc spec is properly parsed. > > > Diffs > ----- > > src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 > src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_appc_tests.cpp > 061f80c62319817b22a5c1880a4858fdafbfb72a > > Diff: https://reviews.apache.org/r/49208/diff/ > > > Testing > ------- > > Make check > > > Thanks, > > Srinivas Brahmaroutu > >
