----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review140808 -----------------------------------------------------------
Thanks, Srini! This patch looks good to me. Please address my comments. I will give a `ship it` once you update. src/tests/containerizer/appc_spec_tests.cpp (line 32) <https://reviews.apache.org/r/49208/#comment206151> one more newline here. src/tests/containerizer/appc_spec_tests.cpp (lines 36 - 73) <https://reviews.apache.org/r/49208/#comment206150> Not yours, it is a tech debt. Could you please use `R"~(...)~"` express the json string? Please follow `DockerSpecTest::ParseV2ImageManifest` for example. Thanks. src/tests/containerizer/appc_spec_tests.cpp (line 76) <https://reviews.apache.org/r/49208/#comment206149> We should use `ASSERT_SOME()` here. src/tests/containerizer/appc_spec_tests.cpp (line 80) <https://reviews.apache.org/r/49208/#comment206153> We should firstly check `has_workingDirectory()` right? Otherwise, it may segfault if not existed. src/tests/containerizer/appc_spec_tests.cpp (line 103) <https://reviews.apache.org/r/49208/#comment206154> Add one more newline. src/tests/containerizer/provisioner_appc_tests.cpp (line 109) <https://reviews.apache.org/r/49208/#comment206152> Add one more newline. - Gilbert Song On June 29, 2016, 11 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49208/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 11 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added tests to check if appc spec is properly parsed. > > > Diffs > ----- > > src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41 > src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_appc_tests.cpp > 061f80c62319817b22a5c1880a4858fdafbfb72a > > Diff: https://reviews.apache.org/r/49208/diff/ > > > Testing > ------- > > Make check > > > Thanks, > > Srinivas Brahmaroutu > >
