----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review142087 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/appc_spec_tests.cpp (lines 38 - 75) <https://reviews.apache.org/r/49208/#comment207582> Diito. src/tests/containerizer/appc_spec_tests.cpp (line 83) <https://reviews.apache.org/r/49208/#comment207579> ASSERT_TRUE src/tests/containerizer/appc_spec_tests.cpp (line 84) <https://reviews.apache.org/r/49208/#comment207578> ASSERT_TRUE src/tests/containerizer/appc_spec_tests.cpp (lines 101 - 105) <https://reviews.apache.org/r/49208/#comment207580> Indentation issue. Move 2 speces to the left. src/tests/containerizer/appc_spec_tests.cpp (lines 118 - 123) <https://reviews.apache.org/r/49208/#comment207581> ditto. src/tests/containerizer/appc_spec_tests.cpp (lines 145 - 211) <https://reviews.apache.org/r/49208/#comment207583> Ditto. src/tests/containerizer/appc_spec_tests.cpp (line 219) <https://reviews.apache.org/r/49208/#comment207585> ASSERT_TRUE src/tests/containerizer/appc_spec_tests.cpp (line 220) <https://reviews.apache.org/r/49208/#comment207586> EXPECT_FALSE src/tests/containerizer/appc_spec_tests.cpp (lines 227 - 228) <https://reviews.apache.org/r/49208/#comment207587> ``` EXPECT_EQ( imageManifest->annotations(0).value(), "acbuild set-name \"example.com/hello\"");``` src/tests/containerizer/provisioner_appc_tests.cpp (line 76) <https://reviews.apache.org/r/49208/#comment207588> Kill this line - Gilbert Song On July 12, 2016, 9:14 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49208/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 9:14 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added tests to check if appc spec is properly parsed. > > > Diffs > ----- > > src/Makefile.am 599ebbef6d164fb2a530b55427ddabb5cd607634 > src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_appc_tests.cpp > 061f80c62319817b22a5c1880a4858fdafbfb72a > > Diff: https://reviews.apache.org/r/49208/diff/ > > > Testing > ------- > > Make check > > > Thanks, > > Srinivas Brahmaroutu > >