----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142385 -----------------------------------------------------------
Looks good - just some style stuff below. 3rdparty/stout/include/stout/flags/flags.hpp (line 86) <https://reviews.apache.org/r/50002/#comment207952> s/Load/Loads/ Since we inherit from the Google style guide, function comments should be descriptive rather than imperative: https://google.github.io/styleguide/cppguide.html#Function_Comments 3rdparty/stout/include/stout/flags/flags.hpp (line 92) <https://reviews.apache.org/r/50002/#comment207949> s/prefix/`prefix`/ Suggestion: s/first/also/ 3rdparty/stout/include/stout/flags/flags.hpp (line 94) <https://reviews.apache.org/r/50002/#comment207954> Suggestion: s/exists in the/exists in both the/ 3rdparty/stout/include/stout/flags/flags.hpp (line 103) <https://reviews.apache.org/r/50002/#comment207957> Missing a backtick 3rdparty/stout/include/stout/flags/flags.hpp (line 922) <https://reviews.apache.org/r/50002/#comment207951> s/in to/into/ 3rdparty/stout/tests/flags_tests.cpp (line 533) <https://reviews.apache.org/r/50002/#comment207950> I think this comment could be omitted. - Greg Mann On July 14, 2016, 10:10 p.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50002/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 10:10 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Allow all flags load methods to specify a prefix. > > This also refactors the prefix logic into one place, so that's nice. > Required for the actual fix for passing work_dir in local. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp dd93627 > 3rdparty/stout/tests/flags_tests.cpp 77f3a6a > > Diff: https://reviews.apache.org/r/50002/diff/ > > > Testing > ------- > > Added additional tests to flags_tests.cpp to ensure that prefix works on the > other methods. > > `make check` passes > > > Thanks, > > Ammar Askar > >
