----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50002/#review142178 -----------------------------------------------------------
3rdparty/stout/include/stout/flags/flags.hpp (lines 85 - 94) <https://reviews.apache.org/r/50002/#comment207742> Mind adding comments to these functions saying they also load from environment? 3rdparty/stout/include/stout/flags/flags.hpp (line 871) <https://reviews.apache.org/r/50002/#comment207741> put this back on the previous line. 3rdparty/stout/tests/flags_tests.cpp (line 524) <https://reviews.apache.org/r/50002/#comment207744> back ticks around function signatures. period at the end. ``` `load(prefix, argc, argv)`. ``` 3rdparty/stout/tests/flags_tests.cpp (line 537) <https://reviews.apache.org/r/50002/#comment207745> see above. 3rdparty/stout/tests/flags_tests.cpp (line 550) <https://reviews.apache.org/r/50002/#comment207746> see above. - Vinod Kone On July 13, 2016, 8:53 p.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50002/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 8:53 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Allow all flags load methods to specify a prefix. > > This also refactors the prefix logic into one place, so that's nice. > Required for the actual fix for passing work_dir in local. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flags.hpp > dd9362772d1fbd32638fc7e70126fd49d4a03c68 > 3rdparty/stout/tests/flags_tests.cpp > 77f3a6af110da1ffcdf2b7ab2b66431a6b5c91d3 > > Diff: https://reviews.apache.org/r/50002/diff/ > > > Testing > ------- > > Added additional tests to flags_tests.cpp to ensure that prefix works on the > other methods. > > `make check` passes > > > Thanks, > > Ammar Askar > >
