> On July 18, 2016, 10:30 p.m., Greg Mann wrote: > > src/tests/test_framework_test.sh, line 24 > > <https://reviews.apache.org/r/50003/diff/4/?file=1445257#file1445257line24> > > > > I see what you mean about the failure of these `atexit` statements - I > > also see lots of litter in my /tmp directory, and in fact, this > > TestFramework test was failing for me due to leftover agent metadata in > > `/tmp/mesos/local`. > > > > Before modifying this test in this way, I'd like to get to the bottom > > of the `atexit` behavior so that this will pass reliably. If you like, I > > think you'd be safe getting rid of this part of the diff and leaving the > > TestFramework test as it is. I can cover the case where we don't set the > > `work_dir` as part of https://issues.apache.org/jira/browse/MESOS-5850
Removed the test change for now. - Ammar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142588 ----------------------------------------------------------- On July 18, 2016, 10:51 p.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50003/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 10:51 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Propagate work_dir flag from local runs to agents/masters. > > > Diffs > ----- > > src/local/flags.hpp f0af0d2 > src/local/local.cpp a543aef > > Diff: https://reviews.apache.org/r/50003/diff/ > > > Testing > ------- > > Manually tested that `mesos local` and `mesos-local` run now. Not sure if a > regression test for this would be good, please advise. > > > Thanks, > > Ammar Askar > >
