----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142829 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 381) <https://reviews.apache.org/r/50199/#comment208495> Does it make sense to add a check here to document and check that precondition? src/launcher/fetcher.cpp (line 431) <https://reviews.apache.org/r/50199/#comment208501> Not an issue: just making sure I understood this correctly :-): if there is no user we do not need to create directory i.e., a global/non user-specific cache dir is created upfront? src/launcher/fetcher.cpp (line 448) <https://reviews.apache.org/r/50199/#comment208497> Should we check whether chown was sucessful? src/launcher/fetcher.cpp (line 508) <https://reviews.apache.org/r/50199/#comment208498> Is there a reason to do this outside `createCacheDirectory`? We are already passing fetcherInfo... src/launcher/fetcher.cpp (line 512) <https://reviews.apache.org/r/50199/#comment208499> Should we check whether an error was returned? - Joerg Schad On July 19, 2016, 8:07 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50199/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 8:07 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. > > > Bugs: MESOS-5845 > https://issues.apache.org/jira/browse/MESOS-5845 > > > Repository: mesos > > > Description > ------- > > The fetcher's launcher creates the fetcher cache > directory for each user immediately before an artifact > is fetched. In order to allow this directory to be > created by a different user than the user doing the > fetching, this patch factors out this directory > creation and places it before all fetches occur. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > > Diff: https://reviews.apache.org/r/50199/diff/ > > > Testing > ------- > > `make check` on CentOS 7 was done at the end of this patch chain. > > > Thanks, > > Greg Mann > >
