----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142837 -----------------------------------------------------------
src/launcher/fetcher.cpp (line 433) <https://reviews.apache.org/r/50199/#comment208508> This var may not be necessary. src/launcher/fetcher.cpp (lines 442 - 448) <https://reviews.apache.org/r/50199/#comment208509> Could we move this logic inside `if (item.action() != FetcherInfo::Item::BYPASS_CACHE) {}`? - Gilbert Song On July 19, 2016, 1:54 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50199/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 1:54 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. > > > Bugs: MESOS-5845 > https://issues.apache.org/jira/browse/MESOS-5845 > > > Repository: mesos > > > Description > ------- > > The fetcher's launcher creates the fetcher cache > directory for each user immediately before an artifact > is fetched. In order to allow this directory to be > created by a different user than the user doing the > fetching, this patch factors out this directory > creation and places it before all fetches occur. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > > Diff: https://reviews.apache.org/r/50199/diff/ > > > Testing > ------- > > `sudo make check` on both OSX and CentOS 7 was done at the end of this patch > chain. > > > Thanks, > > Greg Mann > >
