----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review142863 -----------------------------------------------------------
LGTM, module benm's comments. src/master/flags.cpp (line 86) <https://reviews.apache.org/r/49955/#comment208535> // TODO(neilc): This flag is deprecated in 1.0 and will be removed 6 months later. src/master/main.cpp (line 369) <https://reviews.apache.org/r/49955/#comment208536> Instead of doing the validation in two places (master and local), just do this in the validation lambda of the `Flags::add` method. - Vinod Kone On July 12, 2016, 5:40 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49955/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 5:40 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Joris Van > Remoortere, and Vinod Kone. > > > Bugs: MESOS-5833 > https://issues.apache.org/jira/browse/MESOS-5833 > > > Repository: mesos > > > Description > ------- > > This flag was always marked as experimental. Moreover, we plan to change > Mesos so that partitioned agents are always allowed to reregister with > the master; in this world, the strict registry (which is a mechanism for > ensuring that partitioned agents are *never* allowed to reregister with > the master) will not be useful. > > The code that implements the strict registry remains (for the time > being), as do the test cases that depend on this behavior. However, > `mesos-master` will refuse to start if the flag has been specified. > > > Diffs > ----- > > CHANGELOG fee129c6bdfc16d1ac038a23b4b1b097203a1502 > docs/configuration.md 526308a803307da48928f2cf663dfea5deb4b3a1 > docs/high-availability-framework-guide.md > ae5617b8b5a7f82499c4860130f03b2a8c669419 > docs/upgrades.md 431e6b3fab1a066e8f84e2a83ce961ddfb51f647 > src/local/local.cpp a543aef117fea62660d55435be4d66d30f8ee860 > src/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8 > src/master/main.cpp 9775b8a1e5fe51670789805557339bd0737a02b7 > > Diff: https://reviews.apache.org/r/49955/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
