----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review143219 -----------------------------------------------------------
Patch looks great! Reviews applied: [49955] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 22, 2016, 10:53 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49955/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 10:53 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Joris Van > Remoortere, and Vinod Kone. > > > Bugs: MESOS-5833 > https://issues.apache.org/jira/browse/MESOS-5833 > > > Repository: mesos > > > Description > ------- > > This flag was always marked as experimental. This flag controlled > whether the master will behave the same, regardless of whether the > master has failed over. Notably, in Mesos 1.0, enabling this flag would > mean that a partitioned agent would always be refused reregistration, > regardless of whether the master has failed over (by default, the agent > would be allowed to reregister iff the master failed over in the > interim). > > For Mesos 1.1, we'd like to change the behavior so that partitioned > agents are always allowed to reregister (regardless of master > failover). To prevent developers from writing frameworks that depend on > the old, "strict" behavior (partitioned agents are always rerefused > reregistration), we'd like to disable the "--registry_strict" flag. > > The code that implements the strict registry remains, as do the test > cases that depend on this behavior. However, `mesos-master` will refuse > to start if the flag has been specified. > > > Diffs > ----- > > CHANGELOG 6aeec0531d4628aaa33e9a887ac6598000c843cd > docs/configuration.md d40aa7fbba107f0c8271070ea77946b4815f84e6 > docs/high-availability-framework-guide.md > ae5617b8b5a7f82499c4860130f03b2a8c669419 > docs/upgrades.md 82b9e267f2926d86c1e73873d1224d9883dfbcdc > src/local/local.cpp a1a9a6ba3ea12b60b2567de5b954264eadea2db9 > src/master/flags.cpp 176133fe916aec04a879622b84dcbee0ef52d8e5 > src/master/main.cpp 6146c319b10cd165d9af65832e1e8dbdaafb1aa5 > > Diff: https://reviews.apache.org/r/49955/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
