----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review143216 -----------------------------------------------------------
Bad patch! Reviews applied: [49955] Failed command: ./support/apply-review.sh -n -r 49955 Error: 2016-07-22 10:44:53 URL:https://reviews.apache.org/r/49955/diff/raw/ [6349/6349] -> "49955.patch" [1] error: patch failed: CHANGELOG:188 error: CHANGELOG: patch does not apply error: patch failed: docs/upgrades.md:64 error: docs/upgrades.md: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/14420/console - Mesos ReviewBot On July 22, 2016, 8:08 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49955/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 8:08 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Joris Van > Remoortere, and Vinod Kone. > > > Bugs: MESOS-5833 > https://issues.apache.org/jira/browse/MESOS-5833 > > > Repository: mesos > > > Description > ------- > > This flag was always marked as experimental. This flag controlled > whether the master will behave the same, regardless of whether the > master has failed over. Notably, in Mesos 1.0, enabling this flag would > mean that a partitioned agent would always be refused reregistration, > regardless of whether the master has failed over (by default, the agent > would be allowed to reregister iff the master failed over in the > interim). > > For Mesos 1.1, we'd like to change the behavior so that partitioned > agents are always allowed to reregister (regardless of master > failover). To prevent developers from writing frameworks that depend on > the old, "strict" behavior (partitioned agents are always rerefused > reregistration), we'd like to disable the "--registry_strict" flag. > > The code that implements the strict registry remains, as do the test > cases that depend on this behavior. However, `mesos-master` will refuse > to start if the flag has been specified. > > > Diffs > ----- > > CHANGELOG d55e7e8386abbdf26f8d1075f0a54200d6eb6bc0 > docs/configuration.md de211cacbe06a75f3f2c3bb5a8f20e708cf57bae > docs/high-availability-framework-guide.md > ae5617b8b5a7f82499c4860130f03b2a8c669419 > docs/upgrades.md 80aa8f45e8a82693893e1df4fe7ac03da4fcaac1 > src/local/local.cpp a543aef117fea62660d55435be4d66d30f8ee860 > src/master/flags.cpp ca3e80bf9467328892be89718e5e0a1a05264ab8 > src/master/main.cpp 9775b8a1e5fe51670789805557339bd0737a02b7 > > Diff: https://reviews.apache.org/r/49955/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
