----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/ -----------------------------------------------------------
Review request for mesos and Vinod Kone. Repository: mesos Description ------- These tests relied on the implementation detail that when an agent is removed from the list of registered agents, the master sends a ShutdownSlaveMessage to the agent. That will change in the future (MESOS-4049). To prepare for this future planned behavior, adjust these tests to be more robust by instead looking for the invocation of the `slaveLost` scheduler callback. Diffs ----- src/tests/slave_tests.cpp b9fa85dc1ae0922a100786fcb01156b90a013d2a Diff: https://reviews.apache.org/r/50422/diff/ Testing ------- make check Validated that when the "cancel pending slave removal on receipt of ping" code is removed, `CancelSlaveRemoval` still fails. Thanks, Neil Conway
