----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143484 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 3577) <https://reviews.apache.org/r/49616/#comment209298> move this right before 3608? src/tests/hierarchical_allocator_tests.cpp (line 3613) <https://reviews.apache.org/r/49616/#comment209292> <p>s/unsigned/size_t</p> src/tests/hierarchical_allocator_tests.cpp (line 3615) <https://reviews.apache.org/r/49616/#comment209290> We can also add the elapse time of adding those framework here like other benchmark test in allocator, you can take a look at https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3645 as reference. src/tests/hierarchical_allocator_tests.cpp (line 3617) <https://reviews.apache.org/r/49616/#comment209297> You are losing `Clock::settle();` here as we need to wait till all `addFramework` finished. src/tests/hierarchical_allocator_tests.cpp (line 3623) <https://reviews.apache.org/r/49616/#comment209294> s/string agentTotal/const string agentTotal src/tests/hierarchical_allocator_tests.cpp (line 3625) <https://reviews.apache.org/r/49616/#comment209289> What about adding some check for the ranges? An example is here: https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3657-L3659 BTW: It is `createRange` and `createPortRanges` src/tests/hierarchical_allocator_tests.cpp (line 3627) <https://reviews.apache.org/r/49616/#comment209293> s/unsigned/size_t src/tests/hierarchical_allocator_tests.cpp (lines 3628 - 3629) <https://reviews.apache.org/r/49616/#comment209295> new line here src/tests/hierarchical_allocator_tests.cpp (line 3637) <https://reviews.apache.org/r/49616/#comment209296> Add the elapse time of adding slave here, an example here https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3714 - Guangya Liu On 七月 26, 2016, 5:29 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated 七月 26, 2016, 5:29 a.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > docs/contributors.yaml b8ecdad2591ba5ee0de50e970b7276587db22270 > src/tests/gc_tests.cpp 11a31dbb8d12bfb8a7f10c8eb87154289ac96f62 > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.SuppressOffers*" make check > > > Thanks, > > Jacob Janco > >
