----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review143861 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 486) <https://reviews.apache.org/r/49827/#comment209801> Would love to understand why test will cause this issue. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 496 - 497) <https://reviews.apache.org/r/49827/#comment209802> cleanups.push_back(subsystem->cleanup(...)); src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 500) <https://reviews.apache.org/r/49827/#comment209803> I'd prefer we use await() so that we can get the error message for each subsystem. I feel like we should consistently use await in this file (instead of collect). Can you follow up with patches to do that? src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 533 - 537) <https://reviews.apache.org/r/49827/#comment209800> This should be a CHECK? - Jie Yu On July 26, 2016, 5:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49827/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 5:11 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::cleanup`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 348f105f9c3109a02f1dde0649f1b829cb9ddd04 > > Diff: https://reviews.apache.org/r/49827/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
