----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50634/#review144367 -----------------------------------------------------------
Looks good but looks like this will potentially break the `HTTP_PARSER_VERSION_MAJOR < 2` case. 3rdparty/libprocess/src/decoder.hpp (lines 230 - 262) <https://reviews.apache.org/r/50634/#comment210414> It's a bit unintuitive to run this code in the `HTTP_PARSER_VERSION_MAJOR < 2` case against an empty url, or it's incorrect if on_url is called in `HTTP_PARSER_VERSION_MAJOR < 2`. Any reason you didn't add an `#ifdef`? I would also be ok with removing support for the < 2 parser to simplify things, since it's very old at this point and it seems unlikely anyone would build against a system installed version that is < 2. 3rdparty/libprocess/src/decoder.hpp (lines 232 - 233) <https://reviews.apache.org/r/50634/#comment210413> I'm confused by this note, in that you said "may" but it seems to be definitely the case (although see my other comment about this being brittle in the `HTTP_PARSER_VERSION_MAJOR < 2` case). Do we need this NOTE? Seems clear to me that we need to fill in decoder->query before we can pass it to http::query::decode (if that's what this is saying). 3rdparty/libprocess/src/decoder.hpp (lines 250 - 252) <https://reviews.apache.org/r/50634/#comment210374> Since you're moving this, shall we make it consistent with the other code and clear it within on_message_begin alongside clearing the url and query? - Benjamin Mahler On July 30, 2016, 11:36 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50634/ > ----------------------------------------------------------- > > (Updated July 30, 2016, 11:36 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-5943 > https://issues.apache.org/jira/browse/MESOS-5943 > > > Repository: mesos > > > Description > ------- > > Libprocess: [2/2] Fixed decoder to support incremental URL parsing. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > c0cefd4bdc55049ca0b0f63cd463de5ab30d952b > > Diff: https://reviews.apache.org/r/50634/diff/ > > > Testing > ------- > > make check. > Verified that the incremental parsing tests passed. > Re-ran original repro that broke scheduler driver connection. Verified the > behavior was no longer re-producible. > > > Thanks, > > Joris Van Remoortere > >
