----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50634/#review144443 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/decoder.hpp (line 158) <https://reviews.apache.org/r/50634/#comment210458> No longer need 'result'? Can directly return 0 now like the others? - Benjamin Mahler On Aug. 2, 2016, 1:53 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50634/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 1:53 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-5943 > https://issues.apache.org/jira/browse/MESOS-5943 > > > Repository: mesos > > > Description > ------- > > Libprocess: [2/3] Fixed decoder to support incremental URL parsing. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > c0cefd4bdc55049ca0b0f63cd463de5ab30d952b > > Diff: https://reviews.apache.org/r/50634/diff/ > > > Testing > ------- > > make check. > Verified that the incremental parsing tests passed. > Re-ran original repro that broke scheduler driver connection. Verified the > behavior was no longer re-producible. > > > Thanks, > > Joris Van Remoortere > >
