> On Aug. 1, 2016, 9:54 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 271-273 > > <https://reviews.apache.org/r/50634/diff/1/?file=1458642#file1458642line271> > > > > Since you're moving this, shall we make it consistent with the other > > code and clear it within on_message_begin alongside clearing the url and > > query?
I used string assignment to make these all consistent, but still within the url parsing section. The `on_message_begin` will default construct a new url within the request. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50634/#review144367 ----------------------------------------------------------- On Aug. 2, 2016, 1:53 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50634/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 1:53 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. > > > Bugs: MESOS-5943 > https://issues.apache.org/jira/browse/MESOS-5943 > > > Repository: mesos > > > Description > ------- > > Libprocess: [2/3] Fixed decoder to support incremental URL parsing. > > > Diffs > ----- > > 3rdparty/libprocess/src/decoder.hpp > c0cefd4bdc55049ca0b0f63cd463de5ab30d952b > > Diff: https://reviews.apache.org/r/50634/diff/ > > > Testing > ------- > > make check. > Verified that the incremental parsing tests passed. > Re-ran original repro that broke scheduler driver connection. Verified the > behavior was no longer re-producible. > > > Thanks, > > Joris Van Remoortere > >
