----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144598 -----------------------------------------------------------
include/mesos/v1/mesos.proto (line 339) <https://reviews.apache.org/r/36816/#comment210629> Marathon does the following for health checks: > A health check is considered passing ifits HTTP response code is between 200 and 399, inclusive. What do you think about adopting this as the default behaviour and later adding support for specifying healthy/unhealthy response code ranges? src/health-check/health_checker.hpp (lines 283 - 284) <https://reviews.apache.org/r/36816/#comment210637> We should also document if libprocess validates the certificate or not. If it does try to validate the certificate, then using `localhost` for the domain might be a problem. - Gastón Kleiman On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 1:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Supported HTTP/HTTPS in health check. > > > Diffs > ----- > > include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > src/health-check/health_checker.hpp > b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > ------- > > * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and > HealthCheckTest.HealthyTaskNotMatchHttpStatuses > make check > > > Thanks, > > haosdent huang > >
