> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 280 > > <https://reviews.apache.org/r/36816/diff/17/?file=1465465#file1465465line280> > > > > Do you think we should add "/" if the user has not specified anything?
Use "" instead, thx! > On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > <https://reviews.apache.org/r/36816/diff/17/?file=1465465#file1465465line330> > > > > Why do you need to discard original future here? I saw we discard original future in every `after` callback. So I discard it here as well. > On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 332 > > <https://reviews.apache.org/r/36816/diff/17/?file=1465465#file1465465line332> > > > > It's unclear, what exactly is pending. How about: "CURL has not > > returned after " + stringify(timeout) + "; aborting" I change to `"Aborting because curl has not returned after " + stringify(timeout))` - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review145451 ----------------------------------------------------------- On Aug. 7, 2016, 6:21 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2016, 6:21 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Supported HTTP/HTTPS in health check. > > > Diffs > ----- > > src/health-check/health_checker.hpp > b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 > src/health-check/health_checker.cpp > 585a0b565d948cfa292bad818a710501a4ce0daf > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > ------- > > * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and > HealthCheckTest.HealthyTaskNotMatchHttpStatuses > make check > > > Thanks, > > haosdent huang > >
