----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review144613 -----------------------------------------------------------
src/health-check/health_checker.hpp (line 316) <https://reviews.apache.org/r/49360/#comment210638> s/health TCP check/TCP health check/ src/health-check/health_checker.hpp (line 322) <https://reviews.apache.org/r/49360/#comment210639> I'd change the message to: "Failed to resolve host name" src/health-check/health_checker.cpp (lines 56 - 72) <https://reviews.apache.org/r/49360/#comment210640> This can be simplified if you used the "union trick" suggested by AlexR in https://reviews.apache.org/r/36816 - Gastón Kleiman On Aug. 1, 2016, 1:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49360/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 1:15 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, > Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3567 > https://issues.apache.org/jira/browse/MESOS-3567 > > > Repository: mesos > > > Description > ------- > > Supported TCP check in health check. > > > Diffs > ----- > > include/mesos/mesos.proto 590e169108b2ce5881734ec7f4b01cef9937461a > include/mesos/v1/mesos.proto 94b59dd75abfa9e8601e59f7a20dfd94bc88fa70 > src/health-check/health_checker.hpp > b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 > src/health-check/health_checker.cpp > 585a0b565d948cfa292bad818a710501a4ce0daf > > Diff: https://reviews.apache.org/r/49360/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
