----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50866/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Repository: mesos Description ------- This is a follow up action for https://reviews.apache.org/r/49616/, updating the logic for `offerCallback` would make the code easy to understand and consistent with all other benchmark tests. Diffs ----- src/tests/hierarchical_allocator_tests.cpp cbed333f497016fe2811f755028796012b41db77 Diff: https://reviews.apache.org/r/50866/diff/ Testing ------- make make check ``` ./bin/mesos-tests.sh --benchmark --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0" [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 Using 1000 agents and 1 frameworks Added 1 frameworks in 3007us Added 1000 agents in 661640us round 0 allocate() took 249901us to make 0 offers after filtering 1000 offers round 1 allocate() took 236029us to make 0 offers after filtering 1000 offers [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 (2110 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (2110 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2121 ms total) [ PASSED ] 1 test. ``` ``` ./bin/mesos-tests.sh --benchmark --gtest_filter="*HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0" [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 Using 1000 agents and 1 frameworks Added 1 frameworks in 767us Added 1000 agents in 458795us round 0 allocate() took 230443us to make 0 offers after filtering 1000 offers round 1 allocate() took 231085us to make 0 offers after filtering 1000 offers [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 (1731 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (1731 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1743 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu
