> On 八月 6, 2016, 1:06 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 295-299 > > <https://reviews.apache.org/r/50871/diff/1/?file=1464998#file1464998line295> > > > > I think we may need a test case to cover select backend smartly? > > Gilbert Song wrote: > This really depends on different OS and default kernel medules. It would > be hard to keep consistent behavior. BTW, we may add aufs later.
Agree, but I think that we can always construct some pre-conditions for the test cases and then using `expect` to validate the expected backend. In my understanding, the `auto backend` is also a feature and it is better to have a test case to cover this. ;-) - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review145032 ----------------------------------------------------------- On 八月 5, 2016, 11:27 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50871/ > ----------------------------------------------------------- > > (Updated 八月 5, 2016, 11:27 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5931 > https://issues.apache.org/jira/browse/MESOS-5931 > > > Repository: mesos > > > Description > ------- > > Supported auto backend in Unified Containerizer. > > > Diffs > ----- > > docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 6fc56522a72cda41d8af91a054feb7bfb9048531 > src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 > src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/50871/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >
