----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review145032 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 282 - 283) <https://reviews.apache.org/r/50871/#comment211193> what about a new line here? src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 286 - 292) <https://reviews.apache.org/r/50871/#comment211191> Just a question here: Since now the overlay backend support both single layer and multiple layer images, do we still need to keep the bind backend? Seems it can be covered by overly backend? src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 295 - 299) <https://reviews.apache.org/r/50871/#comment211192> I think we may need a test case to cover select backend smartly? - Guangya Liu On 八月 5, 2016, 11:27 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50871/ > ----------------------------------------------------------- > > (Updated 八月 5, 2016, 11:27 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5931 > https://issues.apache.org/jira/browse/MESOS-5931 > > > Repository: mesos > > > Description > ------- > > Supported auto backend in Unified Containerizer. > > > Diffs > ----- > > docs/configuration.md d6a7eb02b9f3e0011d52ccfd3093167bb6adccd3 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 6fc56522a72cda41d8af91a054feb7bfb9048531 > src/slave/flags.hpp 58fba4a22d988ac6612fc3af8a9346f0b8f8bb51 > src/slave/flags.cpp b8ecc98721c52dcd59a0cc1333421d4f024fbe96 > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/50871/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >
