----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review145340 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 147) <https://reviews.apache.org/r/50947/#comment211535> The `external containerizers` was already removed in https://reviews.apache.org/r/50914/ src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 148 - 155) <https://reviews.apache.org/r/50947/#comment211534> What about ``` // Don't allow the `--nvidia-gpu_devices` flag without the GPU isolator // when using `mesos` containerizer. if (strings::contains(flags.containerizers, "mesos") && flags.nvidia_gpu_devices.isSome() && isolators.count("gpu/nvidia") == 0) { return Error("'--nvidia_gpus_devices' can only be specified if the" " `--isolation` flag contains 'gpu/nvidia'"); } ``` src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 152) <https://reviews.apache.org/r/50947/#comment211537> Not yours, but we prefer adding the space in the first line, which is ``` return Error("'--nvidia_gpus_devices' can only be specified if the " ``` src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 153) <https://reviews.apache.org/r/50947/#comment211536> What about update the message here as well by highlighting `mesos containerizer`? Such as ``` return Error("'--nvidia_gpus_devices' can only be specified if the " "`--isolation` flag contains 'gpu/nvidia' with `mesos` " "containerizer"); ``` - Guangya Liu On 八月 10, 2016, 10:33 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50947/ > ----------------------------------------------------------- > > (Updated 八月 10, 2016, 10:33 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while > docker and external containerizers do not need it anymore. This removed > the 'gpu/nvidia' isolator check for docker and external containerizers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > c1a87e9e5c07529bc1d077f68477108a40506806 > > Diff: https://reviews.apache.org/r/50947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
