----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review145480 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (lines 146 - 149) <https://reviews.apache.org/r/50947/#comment211724> ``` // Mesos containerizer needs to enable isolator flag "gpu/nvidia" to use // GPUs, we don't allow the `--nvidia-gpu_devices` flag without the GPU // isolator; For docker containerizers, this limitation is not set. ``` src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 147) <https://reviews.apache.org/r/50947/#comment211722> s/For docker and external containerizers/For docker containerizers The external containerizer was already removed. - Guangya Liu On 八月 11, 2016, 8:38 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50947/ > ----------------------------------------------------------- > > (Updated 八月 11, 2016, 8:38 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5975 > https://issues.apache.org/jira/browse/MESOS-5975 > > > Repository: mesos > > > Description > ------- > > Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while > docker and external containerizers do not need it anymore. This removed > the 'gpu/nvidia' isolator check for docker and external containerizers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp > c1a87e9e5c07529bc1d077f68477108a40506806 > > Diff: https://reviews.apache.org/r/50947/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
