> On 八月 10, 2016, 3:08 p.m., Guangya Liu wrote:
> > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp, line 153
> > <https://reviews.apache.org/r/50947/diff/1/?file=1469752#file1469752line153>
> >
> > What about update the message here as well by highlighting `mesos
> > containerizer`?
> >
> > Such as
> >
> > ```
> > return Error("'--nvidia_gpus_devices' can only be specified if the "
> > "`--isolation` flag contains 'gpu/nvidia' with `mesos` "
> > "containerizer");
> > ```
Correct a typo here: I prefer that we use `'` but not ``` for the error message.
```
return Error("'--nvidia_gpus_devices' can only be specified if the "
"'--isolation' flag contains 'gpu/nvidia' with 'mesos' "
"containerizer");
```
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review145340
-----------------------------------------------------------
On 八月 10, 2016, 10:33 a.m., Yubo Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> -----------------------------------------------------------
>
> (Updated 八月 10, 2016, 10:33 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and
> Rajat Phull.
>
>
> Bugs: MESOS-5975
> https://issues.apache.org/jira/browse/MESOS-5975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/allocator.cpp
> c1a87e9e5c07529bc1d077f68477108a40506806
>
> Diff: https://reviews.apache.org/r/50947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yubo Li
>
>
