> On Aug. 12, 2016, 9:14 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/ssl/flags.hpp, line 16 > > <https://reviews.apache.org/r/51015/diff/1/?file=1471653#file1471653line16> > > > > Why are the contents of this file ifdef'd out here? Shouldn't the > > ifdef-ing be done by the includer?
Check the other public headers in that folder - we seem to not exclude public headers via guards but do that in the headers themselves. > On Aug. 12, 2016, 9:14 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/include/process/ssl/flags.hpp, lines 13-14 > > <https://reviews.apache.org/r/51015/diff/1/?file=1471653#file1471653line13> > > > > This should be: `__PROCESS_SSL_FLAGS_HPP__` Did we finally come up with a rule here? - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51015/#review145660 ----------------------------------------------------------- On Aug. 12, 2016, 9:11 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51015/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 9:11 p.m.) > > > Review request for mesos, Joris Van Remoortere and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > For allowing modules to identify the current SSL specific setup of > their hosting process (master, agent, ...), the libprocess SSL flags > are now being publically exposed. > The newly added flags.hpp is guarded by a `USE_SSL_SOCKET` define > check. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > a27e9f7aaa2b45139d4eb95f365d8b2041d7aad2 > 3rdparty/libprocess/include/process/ssl/flags.hpp PRE-CREATION > 3rdparty/libprocess/src/openssl.hpp > f33614c82cefbf1c74a74ba9b3fa02105d0bec5b > 3rdparty/libprocess/src/openssl.cpp > a73313b3221d6c80b35f21c00f35d9f9c795f1ec > > Diff: https://reviews.apache.org/r/51015/diff/ > > > Testing > ------- > > make check on final RR. > > NOTE: No functional changes involved. > > > Thanks, > > Till Toenshoff > >
