----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51015/#review145664 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/ssl/flags.hpp (lines 27 - 28) <https://reviews.apache.org/r/51015/#comment212000> This comment would benefit from a tweak: ``` /** * Defines the _global_ OpenSSL configuration loaded by libprocess. * These flags are captured from environment variables with the * prefix "LIBPROCESS_SSL_". */ ``` 3rdparty/libprocess/include/process/ssl/flags.hpp (lines 50 - 51) <https://reviews.apache.org/r/51015/#comment211996> I'll add a small comment here before committing: ``` /** * Returns the _global_ OpenSSL context used by libprocess. */ ``` - Joseph Wu On Aug. 12, 2016, 2:11 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51015/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 2:11 p.m.) > > > Review request for mesos, Joris Van Remoortere and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > For allowing modules to identify the current SSL specific setup of > their hosting process (master, agent, ...), the libprocess SSL flags > are now being publically exposed. > The newly added flags.hpp is guarded by a `USE_SSL_SOCKET` define > check. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > a27e9f7aaa2b45139d4eb95f365d8b2041d7aad2 > 3rdparty/libprocess/include/process/ssl/flags.hpp PRE-CREATION > 3rdparty/libprocess/src/openssl.hpp > f33614c82cefbf1c74a74ba9b3fa02105d0bec5b > 3rdparty/libprocess/src/openssl.cpp > a73313b3221d6c80b35f21c00f35d9f9c795f1ec > > Diff: https://reviews.apache.org/r/51015/diff/ > > > Testing > ------- > > make check on final RR. > > NOTE: No functional changes involved. > > > Thanks, > > Till Toenshoff > >
