----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51062/#review145790 -----------------------------------------------------------
Ship it! src/examples/long_lived_executor.cpp (line 115) <https://reviews.apache.org/r/51062/#comment212154> Do we actually want to implement this? Maybe add a little bit about what it would mean. src/examples/test_http_executor.cpp (lines 161 - 165) <https://reviews.apache.org/r/51062/#comment212161> Do we actually want to implement this? Maybe add a little bit about what it would mean. src/launcher/executor.cpp (lines 200 - 201) <https://reviews.apache.org/r/51062/#comment212160> I suppose a scheduler (in the future) could target the task to an executor id that corresponds to a command executor that it previously launched. Maybe just say that this should not be possible since we choose the group-capable default executor if there is a launch group message? It's not clear to me that the master would always be the one to prevent this from happening. - Benjamin Mahler On Aug. 12, 2016, 11:13 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51062/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 11:13 p.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, > James DeFelice, and Jie Yu. > > > Bugs: MESOS-6036 > https://issues.apache.org/jira/browse/MESOS-6036 > > > Repository: mesos > > > Description > ------- > > This event is used to deliver a task group atomically to an executor. > > > Diffs > ----- > > include/mesos/executor/executor.proto > 9aa046e0e2421e8bb7678e53366970589d41e6d7 > include/mesos/v1/executor/executor.proto > 5e76e4e630d75673bd5647704a699134b2038338 > src/examples/long_lived_executor.cpp > 5c1fde195f1e6b599b025d771edd7e9841e51c61 > src/examples/test_http_executor.cpp > 19d0f684ece0e7a57c803ad541535824ee45131f > src/launcher/executor.cpp 7967684e42c97326770bd83a41c2d4b1338a511f > src/tests/mesos.hpp 59688dc9d1b16f20facf272085e65b3835f9a56e > > Diff: https://reviews.apache.org/r/51062/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
