----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review146059 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (lines 4003 - 4004) <https://reviews.apache.org/r/49617/#comment212427> You can simplify this as following: ``` initialize(master::Flags(), offerCallback); ``` src/tests/hierarchical_allocator_tests.cpp (line 4035) <https://reviews.apache.org/r/49617/#comment212428> Just FYI: When create agent, the API `createSlaveInfo` need to parse the resources in every loop, this is not good to evaluate the add agent performance, I created a patch here to remove the logic of parse resources in `createSlaveInfo` https://reviews.apache.org/r/50693/ src/tests/hierarchical_allocator_tests.cpp (lines 4045 - 4046) <https://reviews.apache.org/r/49617/#comment212429> new line here src/tests/hierarchical_allocator_tests.cpp (line 4051) <https://reviews.apache.org/r/49617/#comment212432> What about update the comments as ``` // Deactivates the framework to make sure it will not got resources any more. ``` src/tests/hierarchical_allocator_tests.cpp (lines 4051 - 4065) <https://reviews.apache.org/r/49617/#comment212434> What about adding time elapse here for `deactivateFramework`? The time elapse should include both `deactivateFramework` and `recoverResources`. src/tests/hierarchical_allocator_tests.cpp (line 4106) <https://reviews.apache.org/r/49617/#comment212438> I think we can remove this? src/tests/hierarchical_allocator_tests.cpp (line 4109) <https://reviews.apache.org/r/49617/#comment212435> What about update the message as ``` cout << "allocator settled after " << watch.elapsed() << " with activate/suppress " << addFrameworkCount << endl; ``` - Guangya Liu On 八月 17, 2016, 2:26 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49617/ > ----------------------------------------------------------- > > (Updated 八月 17, 2016, 2:26 a.m.) > > > Review request for mesos, Joris Van Remoortere and Jiang Yan Xu. > > > Bugs: MESOS-5780 > https://issues.apache.org/jira/browse/MESOS-5780 > > > Repository: mesos > > > Description > ------- > > - This benchmark measures latency to stability of > the allocator following disconnection and > reconnection of all frameworks. > - In this scenario, frameworks are offered resources > and suppressed in batches. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > cbed333f497016fe2811f755028796012b41db77 > > Diff: https://reviews.apache.org/r/49617/diff/ > > > Testing > ------- > > MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK_Test.FrameworkFailover*" make check > > Sample Output: > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23 > Using 10000 agents and 6000 frameworks > Added 6000 frameworks in 113410us > Added 10000 agents in 6.83980663333333mins > allocator settled after 3.28683733333333mins > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/23 > (609255 ms)[ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24 > Using 20000 agents and 1 frameworks > Added 1 frameworks in 190us > Added 20000 agents in 4.752954secs > allocator settled after 7us > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/24 > (6332 ms) > > > Thanks, > > Jacob Janco > >
