----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review146302 -----------------------------------------------------------
src/docker/docker.hpp (lines 101 - 102) <https://reviews.apache.org/r/50128/#comment212677> Keep the two `<<` aligned with each other. ``` LOG(WARNING) << "Parse device information error for '" << device << "', PathInHost:PathInContainer:Permission expected"; ``` src/docker/docker.cpp (lines 760 - 761) <https://reviews.apache.org/r/50128/#comment212680> I think we need to keep the original blank line here - Guangya Liu On 八月 15, 2016, 7:26 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 八月 15, 2016, 7:26 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device' > to handle data tranformation between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
