----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review146263 -----------------------------------------------------------
src/tests/containerizer/docker_containerizer_tests.cpp (line 3822) <https://reviews.apache.org/r/50127/#comment212646> s/Future<vector<Offer> >/Future<vector<Offer>> src/tests/containerizer/docker_containerizer_tests.cpp (line 3893) <https://reviews.apache.org/r/50127/#comment212670> A question here: Why expect false here? Can you please add some comments here? src/tests/containerizer/docker_containerizer_tests.cpp (line 3910) <https://reviews.apache.org/r/50127/#comment212671> ditto src/tests/containerizer/docker_containerizer_tests.cpp (lines 3945 - 3946) <https://reviews.apache.org/r/50127/#comment212669> I'd prefer that we `destroy` the container directly but not wait 1000s till the container exist, this would help speed up the unit test speed. src/tests/containerizer/docker_containerizer_tests.cpp (line 3954) <https://reviews.apache.org/r/50127/#comment212672> four spaces - Guangya Liu On 八月 15, 2016, 7:30 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50127/ > ----------------------------------------------------------- > > (Updated 八月 15, 2016, 7:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added a testing case for end-to-end GPU support for docker > containerizer. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 42d4364b6fcbc94c7852721511001c103cb5a90d > > Diff: https://reviews.apache.org/r/50127/diff/ > > > Testing > ------- > > GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j > check > > > Thanks, > > Yubo Li > >
