----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146724 -----------------------------------------------------------
src/slave/containerizer/docker.hpp (lines 20 - 25) <https://reviews.apache.org/r/50123/#comment213307> What does adding all of these headers have to do with this patch? They may be needed, but I don't see why they would be part of this patch, specifically. src/slave/containerizer/docker.cpp (line 19) <https://reviews.apache.org/r/50123/#comment213318> Again, it's not clear why this is added as part of this commit. I.e. I don't see `set` being used anwywhere in the code that's being added. src/slave/containerizer/docker.cpp (lines 171 - 179) <https://reviews.apache.org/r/50123/#comment213315> It feels a little strange to me to do things this way (i.e. duplicating the `new DockerContainerizer()` call). I would like to see what @bmahler thinks, but I'd prefer something like: ``` Option<NvidiaGpuAllocator> allocator = None(); if (nvidia.isSome()) { allocator = nvidia->allocator; } return new DockerContainerizer( flags, fetcher, Owned<ContainerLogger>(logger.get()), docker, allocator); ``` src/slave/containerizer/docker.cpp (line 1284) <https://reviews.apache.org/r/50123/#comment213312> I would remove this temporary variable and just call the following: ``` Option<double> gpus = taskInfo->resources().gpus(); ``` - Kevin Klues On Aug. 22, 2016, 10:11 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50123/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 10:11 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added 'NvidiaGpuAllocator' to docker containerizer process so that > docker containerizer process is ready to use it to allocate GPUs to task > with 'gpus' resource. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp f2a06065cf99fed934c2c1ffc47461ec8a97f50d > src/slave/containerizer/docker.cpp 5c1ee8e467d1c54c60b67dc5275ef71e1bb90723 > src/tests/mesos.hpp ad31276aeb2cb7ed5ba3e091a9085f35addf17c4 > src/tests/mesos.cpp 62e8fcc6fa7bd856aab6148ca6e6cad66b436f04 > > Diff: https://reviews.apache.org/r/50123/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
