-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50127/#review146841
-----------------------------------------------------------




src/tests/containerizer/docker_containerizer_tests.cpp (lines 3893 - 3894)
<https://reviews.apache.org/r/50127/#comment213573>

    I don't understand this comment. Can you clarify? Why do we want to make 
sure we are not running in privileged mode?



src/tests/containerizer/docker_containerizer_tests.cpp (lines 3897 - 3912)
<https://reviews.apache.org/r/50127/#comment213576>

    Why do you do this twice?



src/tests/containerizer/docker_containerizer_tests.cpp (lines 3914 - 3917)
<https://reviews.apache.org/r/50127/#comment213578>

    What does this have to do with the GPU test? Do we have to check this here?


- Kevin Klues


On Aug. 22, 2016, 10:13 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50127/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 10:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This added a testing case for end-to-end GPU support for docker
> containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 42d4364b6fcbc94c7852721511001c103cb5a90d 
> 
> Diff: https://reviews.apache.org/r/50127/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j 
> check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Reply via email to