> On 八月 22, 2016, 6:12 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3893 > > <https://reviews.apache.org/r/50127/diff/6/?file=1472875#file1472875line3893> > > > > A question here: Why expect false here? Can you please add some > > comments here?
We double-check that docker priviledged mode is not enabled, so that we can get correct GPU exposition in docker container. Added comments here. > On 八月 22, 2016, 6:12 a.m., Guangya Liu wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3910 > > <https://reviews.apache.org/r/50127/diff/6/?file=1472875#file1472875line3910> > > > > ditto For same reason - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review146263 ----------------------------------------------------------- On 八月 15, 2016, 7:30 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50127/ > ----------------------------------------------------------- > > (Updated 八月 15, 2016, 7:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > This added a testing case for end-to-end GPU support for docker > containerizer. > > > Diffs > ----- > > src/tests/containerizer/docker_containerizer_tests.cpp > 42d4364b6fcbc94c7852721511001c103cb5a90d > > Diff: https://reviews.apache.org/r/50127/diff/ > > > Testing > ------- > > GTEST_FILTER="DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch" make -j > check > > > Thanks, > > Yubo Li > >
