----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review146901 -----------------------------------------------------------
src/tests/containerizer/provisioner_appc_tests.cpp (line 504) <https://reviews.apache.org/r/51421/#comment213700> Ditto. src/tests/containerizer/provisioner_appc_tests.cpp (lines 538 - 543) <https://reviews.apache.org/r/51421/#comment213709> Hum, I don't think legitimate case. ContainerState will only container top level executor containers. src/tests/containerizer/provisioner_appc_tests.cpp (lines 547 - 548) <https://reviews.apache.org/r/51421/#comment213705> The comment here is confusing. I think you want to see if a container can have multiple rootfses (for image volumes), right? src/tests/containerizer/provisioner_appc_tests.cpp (lines 558 - 567) <https://reviews.apache.org/r/51421/#comment213713> I don't know if this check is useful. I think the destroy check below sounds sufficient to me. - Jie Yu On Aug. 25, 2016, 8:15 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51421/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 8:15 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added provisioner appc unit test for recovering nested container. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/51421/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
