----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review147739 -----------------------------------------------------------
src/tests/containerizer/provisioner_appc_tests.cpp (line 497) <https://reviews.apache.org/r/51421/#comment214959> missed here? ``` path::join(sandbox.get(), "work_dir"); ``` src/tests/containerizer/provisioner_appc_tests.cpp (lines 531 - 534) <https://reviews.apache.org/r/51421/#comment214977> how about s/ExecutorInfo/`ExecutorInfo` s/ContainerState/`ContainerState` s/ContainerInfo/`ContainerInfo` s/--default_container_info/`--default_container_info` src/tests/containerizer/provisioner_appc_tests.cpp (line 541) <https://reviews.apache.org/r/51421/#comment214961> s/string/const string src/tests/containerizer/provisioner_appc_tests.cpp (lines 541 - 546) <https://reviews.apache.org/r/51421/#comment214976> What about moving this right before #551? Ditto for #553 to #556 - Guangya Liu On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51421/ > ----------------------------------------------------------- > > (Updated 八月 29, 2016, 9:20 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Bugs: MESOS-6067 > https://issues.apache.org/jira/browse/MESOS-6067 > > > Repository: mesos > > > Description > ------- > > Added provisioner appc unit test for recovering nested container. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > b3ba176e506a6d1528290c07a8a0555b12c8cf70 > > Diff: https://reviews.apache.org/r/51421/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
