> On Aug. 25, 2016, 5:58 p.m., Jie Yu wrote:
> > src/tests/containerizer/provisioner_appc_tests.cpp, lines 538-543
> > <https://reviews.apache.org/r/51421/diff/1/?file=1485641#file1485641line538>
> >
> > Hum, I don't think legitimate case. ContainerState will only container
> > top level executor containers.
I have a different thought on this. According to the prvisioner::recover()
```
virtual process::Future<Nothing> recover(
const std::list<mesos::slave::ContainerState>& states,
const hashset<ContainerID>& orphans) const;
```
We are assuming the `orphans` includes all orphaned containers (parent and its
sub-containers). Correspondingly, the `state` should do the same. It would
depend on more changes in MesosContainerizer::recover() to check the
`taskState`. Otherwise, all sub-containers will be destroyed as unknown
orphans. There is no way to recognize alive sub-containers.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51421/#review146901
-----------------------------------------------------------
On Aug. 29, 2016, 2:20 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51421/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2016, 2:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph
> Wu, and Kevin Klues.
>
>
> Bugs: MESOS-6067
> https://issues.apache.org/jira/browse/MESOS-6067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added provisioner appc unit test for recovering nested container.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_appc_tests.cpp
> b3ba176e506a6d1528290c07a8a0555b12c8cf70
>
> Diff: https://reviews.apache.org/r/51421/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
