-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46824/
-----------------------------------------------------------
(Updated Aug. 30, 2016, 4:36 p.m.)
Review request for mesos, Alexander Rukletsov and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335
Repository: mesos
Description
-------
While right now we can technically `add` variables to `Flags` classes
which are not members, the in order to have correct copy semantics for
`Flags` only member variables should be used.
Here we changed all instances to a full pointer-to-member syntax in
the current code.
Diffs (updated)
-----
src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76
src/cli/resolve.cpp 3a12f123e0969382a79d045c15f372e2f5eea02e
src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3
src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3
src/examples/disk_full_framework.cpp 1221f83d495f7c1ee1bcbcfe067e303db0a921eb
src/examples/dynamic_reservation_framework.cpp
850bb2a5b243dd5d5a8b6476570b4f943fde6185
src/examples/load_generator_framework.cpp
5402e31b89b7ead1dc8fdc9065980b5b1c0d380c
src/examples/long_lived_framework.cpp
7c57eb5e4a34208504475013690ae8e3cae74155
src/examples/no_executor_framework.cpp
57425726aa5ca27c9579b0d8ecc0bb9eb9b26852
src/examples/persistent_volume_framework.cpp
3cc7cf0c4c97d90f2e70800d7a8d4ca64c2150d1
src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03
src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62
src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a
src/local/main.cpp 578b65efac1dd8ec201bfcc85de353ca6b867148
src/master/main.cpp 4a1a8e70ab0535aa131681b2b09a99e51c20158e
src/slave/container_loggers/lib_logrotate.hpp
f216548ef37f5c2245ef64d21e84e06100e8e5ae
src/slave/container_loggers/logrotate.hpp
96697d46ca71e7f62119f2fe669230cf5a04242f
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp
55a06cfe1edbb7699c04101f78cc4979176e33f6
src/slave/containerizer/mesos/launch.cpp
13b65d82e029650e150eb2bc3647d95af167bd72
src/slave/containerizer/mesos/mount.cpp
dbd7853a43ee1402f2f91d933a657010efdd76b0
src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb
src/tests/active_user_test_helper.cpp
80bd0acff47689be95a42bad3cb867e0faa68554
src/tests/containerizer/capabilities_test_helper.cpp
f982dbd92a08e3fd2af48e90d98dbbd7e28ca583
Diff: https://reviews.apache.org/r/46824/diff/
Testing
-------
Tested on various platforms in internal CI.
Thanks,
Benjamin Bannier
