----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review147591 -----------------------------------------------------------
src/health-check/health_checker.cpp (lines 178 - 186) <https://reviews.apache.org/r/51560/#comment214788> We don't need to care the compatibility with the old HTTP Health Check protobuf here because custom executor would not use `HealthCheckerProcess`. - haosdent huang On Sept. 1, 2016, 6:18 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51560/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 6:18 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joseph Wu. > > > Bugs: MESOS-6110 > https://issues.apache.org/jira/browse/MESOS-6110 > > > Repository: mesos > > > Description > ------- > > Deprecated using health checks without setting the type. > > > Diffs > ----- > > CHANGELOG eadf546f96e4f8f83107de3e1421197875a46e2b > docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 > include/mesos/mesos.proto 7fbcdf005718ba4d7ec3b02cf70a3fc53d4f4818 > include/mesos/v1/mesos.proto 60ec0cce35e5e2d2f4907efadc7ab92680566ef0 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > > Diff: https://reviews.apache.org/r/51560/diff/ > > > Testing > ------- > > Could verfied from > https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md > > > Thanks, > > haosdent huang > >
