----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148522 -----------------------------------------------------------
Patch looks great! Reviews applied: [51561, 51803, 51560] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 12, 2016, 2:19 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51560/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 2:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and > Jiang Yan Xu. > > > Bugs: MESOS-6110 > https://issues.apache.org/jira/browse/MESOS-6110 > > > Repository: mesos > > > Description > ------- > > Health checks must supply set type field from now on. Additionally, > `HealthCheck.HTTP` message has been renamed to > `HealthCheck.HttpCheckInfo` to avoid naming collisions. > > > Diffs > ----- > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 > > Diff: https://reviews.apache.org/r/51560/diff/ > > > Testing > ------- > > Could verfied from > https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md > > > Thanks, > > haosdent huang > >