----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148486 -----------------------------------------------------------
src/health-check/health_checker.cpp (line 178) <https://reviews.apache.org/r/51560/#comment215935> Mesos 2.0 release src/health-check/health_checker.cpp (lines 178 - 181) <https://reviews.apache.org/r/51560/#comment215937> We should do the same for HTTP src/health-check/health_checker.cpp (line 184) <https://reviews.apache.org/r/51560/#comment215936> Mesos 2.0 release src/health-check/health_checker.cpp (line 615) <https://reviews.apache.org/r/51560/#comment215939> 2.0 src/health-check/health_checker.cpp (line 617) <https://reviews.apache.org/r/51560/#comment215938> s/by/from src/tests/health_check_tests.cpp (line 209) <https://reviews.apache.org/r/51560/#comment215933> // Command health check without `type` should not be rejected. // NOTE: Absence of `type` is supported for compatibility reasons and will be deprecated in Mesos 2.0. src/tests/health_check_tests.cpp (line 220) <https://reviews.apache.org/r/51560/#comment215934> // HTTP health check without `type` should not be rejected. // NOTE: Absence of `type` is supported for compatibility reasons and will be deprecated in Mesos 2.0. - Alexander Rukletsov On Sept. 12, 2016, 1:18 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51560/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 1:18 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and > Jiang Yan Xu. > > > Bugs: MESOS-6110 > https://issues.apache.org/jira/browse/MESOS-6110 > > > Repository: mesos > > > Description > ------- > > Deprecated using health checks without setting the type. > > > Diffs > ----- > > CHANGELOG ef31563e3f4a2ceda598a0ddcc7ad325f64a8538 > docs/upgrades.md dc43cad4d9e0bec0f4017ac53d740687c060b332 > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > src/tests/health_check_tests.cpp 50a252b5267cbc3b21ddc75e1da86c4975f6faf1 > > Diff: https://reviews.apache.org/r/51560/diff/ > > > Testing > ------- > > Could verfied from > https://github.com/haosdent/mesos/blob/85abb6da058bf8daf4e794df7da8eb5f240b671c/docs/upgrades.md > > > Thanks, > > haosdent huang > >
